test: add E2E tests for image upload in editor (#223)#230
Merged
Conversation
Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ Post-merge verification skipped — |
Collaborator
Author
|
✅ UI verification skipped — no UI files changed (only E2E test files). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #223
What
Adds E2E test coverage for the
/imageslash command in the editor. Image upload involves file input handling, network requests to Supabase Storage, and DOM rendering — behaviors that can only be properly tested in a real browser.How
e2e/fixtures/test-image.pngwaitForEvent("filechooser"), provides the test image, and verifies the<img>renders with apage-imagesstorage URL.Testing
pnpm lint✅pnpm typecheck✅pnpm test— 252 passed ✅pnpm test:e2e— 61 passed (including 2 new) ✅